Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propasal of fix for any type typescript error #77

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

simply-now
Copy link

Still learning how best to create types in typescript and I think I solved this files long list of type any errors.

Still learning so don't feel like this has to be added in. Used this to learn how to solve a few type errors.

I also wanted to use your open source project as a starting place for a project I'm working on that generates static profile pages from resume files.

@vercel
Copy link

vercel bot commented Oct 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-resume ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2023 1:10am

@simply-now
Copy link
Author

Adding a bit of clarity on the errors: Examples below there were a lot of similar instances with a few different forms..
This was the first one,
"Parameter 'draft' implicitly has an 'any' type."

after fixing it I had to change how the types were imported and used in indexes for some of the types.
I believe these changes make the code easier to follow and edit if needed as well as making it easier to add/adjust types for new input.

If this seems good I can learn how to format these pull request better. I really like the project and would enjoy contributing more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant