Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle 'surt_ordered: False' #586

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

handle 'surt_ordered: False' #586

wants to merge 1 commit into from

Conversation

ranafayed
Copy link

Description

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Replay fix (fixes a replay specific issue)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed.

@ikreymer
Copy link
Member

Thanks for the PR!
This is not a common use case, but good to have it supported for your workflow!

It looks like the tests are failing with this change so far: https://travis-ci.com/github/webrecorder/pywb/jobs/400118397
Could you take a look, and perhaps also add a test for surt_ordered: false with a small cdx?

Let me know if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ranafayed @ikreymer