Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the table column to display pretty formatted JSON when wrap is set to all #479

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

aaryanpour
Copy link

@aaryanpour aaryanpour commented Aug 29, 2024

Hi team,

Thank you for all the efforts.

In my experience, viewing JSON could be improved across tables (regular and line) in dashboards. Since the data itself is already pretty formatted, it made sense for targetted columns to show the JSON data how one would expect it to look when wrapped across lines.

Example:

table {
      title = "Users with Inline Policies"
      column "inline_policies" {
        wrap = "all"
      }
      sql = <<-EOQ
   select arn, inline_policies from aws_iam_user
  EOQ
    }

image
image

@CLAassistant
Copy link

CLAassistant commented Aug 29, 2024

CLA assistant check
All committers have signed the CLA.

…ap option is set to all (regular and line table)
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Nov 27, 2024
@pskrbasu pskrbasu removed the stale label Nov 29, 2024
@MichaelBurgess
Copy link
Contributor

@aaryanpour are you able to resolve the merge conflict on your fork/branch please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants