Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refac react frontend #790

Open
wants to merge 28 commits into
base: refactor-react-migration
Choose a base branch
from

Conversation

MerlinScheurer
Copy link
Collaborator

@MerlinScheurer MerlinScheurer commented Aug 17, 2024

@MerlinScheurer MerlinScheurer marked this pull request as ready for review September 1, 2024 11:06
@MerlinScheurer MerlinScheurer self-assigned this Sep 1, 2024
@bbilly1
Copy link
Member

bbilly1 commented Nov 8, 2024

For the channel overwrite endpoint, I consolidated that to the channel ID endpoint. E.g.:

POST /api/channel/<channel-id>/
{"channel_overwrites": {"index_playlists": true}}

Then this now also handles None and bools correctly. E.g. to "unset" or "delete" an overwrite set it to null. And True/False for the boolean values respectively.

@MerlinScheurer
Copy link
Collaborator Author

@bbilly1 how do i GET the channel_overwrites now?

@bbilly1
Copy link
Member

bbilly1 commented Nov 9, 2024

They are part of the regular channel data, e.g. /api/channel/<channel-id>/ will have the overwrites, if there are any defined. All keys are optional... so for the channel about page, you should only need one API request to get all needed data.

@MerlinScheurer
Copy link
Collaborator Author

@bbilly1 implemented and it works, but feels a bit quirky. But not sure why that is.
Will have another look tomorrow.

@MerlinScheurer
Copy link
Collaborator Author

Fixed styling selection, it was expecting dark.css to exist as a file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants