This repository was archived by the owner on Feb 8, 2024. It is now read-only.
Allow running without magisk/root again (Fixes #206)#212
Open
Phoenix616 wants to merge 1 commit intosubstratum:devfrom
Open
Allow running without magisk/root again (Fixes #206)#212Phoenix616 wants to merge 1 commit intosubstratum:devfrom
Phoenix616 wants to merge 1 commit intosubstratum:devfrom
Conversation
Also catch error if version couldn't be parsed as an integer.
|
Not sure this is going to do any good, as the Substratum app has essentially been abandoned in favor of the perpetually-in-beta Substratum Lite. 😞 |
Author
|
TIL about a new one existing. Might be good to mention that on the repo 👀 |
|
If I were on the team, that's what I would do. I'd advise you to talk to the team directly, but the Telegram group is the only public place I'm aware of, and there doesn't seem to be a whole lot of chatter from the developers going on there. |
|
|
Phoenix616:pr/fix-no-root-no-magisk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change re-adds the root check which was removed in a previous commit as well as add a general catch for the case where the output of
su -Vcouldn't be parsed as an integer.