Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Fix SQLAlchemy V2 Support #293

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Bugfix: Fix SQLAlchemy V2 Support #293

wants to merge 3 commits into from

Conversation

ADR-007
Copy link

@ADR-007 ADR-007 commented Nov 4, 2023 •
edited
Loading

Todos

  • MIT compatible
  • Tests
  • Documentation just a bugfix
  • Updated CHANGES.rst

@ADR-007 ADR-007 changed the title Fix SQLAlchemy V2 Support Bugfix: Fix SQLAlchemy V2 Support Nov 4, 2023
@DanCardin DanCardin mentioned this pull request Feb 23, 2024
Open
@hishoss
Copy link

hishoss commented May 23, 2024

We need this in main.

@leodrivera leodrivera mentioned this pull request Aug 22, 2024
Merged
@badge
Copy link

badge commented Sep 2, 2024

This PR doesn't give full SQLAlchemy 2.0 support; there are a ton of new methods the dialect that need implementing before reflection works. See all the New in version 2.0. notes here: https://docs.sqlalchemy.org/en/20/core/internals.html#sqlalchemy.engine.default.DefaultDialect.get_multi_pk_constraint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ADR-007 @hishoss @badge