Add redshift_connector example to docs #233
Conversation
|
Docs changes look good. Is redshift_connector python 3 only? I'm not sure whether doctests have any facility to make tests conditional, since the 2.7 version is failing without having redshift_connector installed. I'd be fine with turning off doctests completely for 2.7 if that ends up being easier. |
|
redshift_connector is Python3 only I found this for conditionally skipping tests, though I have run into issues trying to build docs locally, so haven't been able to give it a shot |
lets just make one last release with py2.7 support and then strip py2.7 completely it's also time to remove the "redshift_sqlalchemy compatibility package" |
|
This should be unblocked now that we're python 3 only |
| @@ -6,6 +6,7 @@ | |||
| - Support GEOMETRY, SUPER Redshift datatypes | |||
| (`Pull #235 <https://github.com/sqlalchemy-redshift/sqlalchemy-redshift/pull/235>`_) | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
No change note is needed here, since it doesn't affect behavior.
|
The test on python 3.5 is failing due to not having redshift_connector installed. I think we can go ahead and include redshift_connector in the dependencies for |
|
I've realized python 3.5 support for redshift_connector seems to be broken due to an incompatible dependency -- setting this to a draft while I investigate next steps. |
Todos
Adds redshift_connector as a supported database driver in README. Provide usage example.