Fix Graph.dataDomain where series have empty data array#475
Open
paulcadman wants to merge 3 commits intoshutterstock:mainfrom
Open
Fix Graph.dataDomain where series have empty data array#475paulcadman wants to merge 3 commits intoshutterstock:mainfrom
paulcadman wants to merge 3 commits intoshutterstock:mainfrom
Conversation
added 3 commits
September 5, 2014 10:21
The current implementation of Graph.dataDomain assumes that series data arrays have at least one element. Use case: Displaying a series with no data in the graph's legend.
If Graph.dataDomain() is not restricted to active series then for
unstacked charts RangeSlider.Preview may set graph.window.{xMin, xMax}
to an incorrect value when series are disabled using the Toggle
behaviour.
This fixes:
shutterstock#497
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of Graph.dataDomain assumes that series data arrays have at least one element.
Use case: Displaying a series with no data in the graph's legend but I still want to use the dataDomain method.