Added the possibility to add a minumum and maximum x value.#457
Open
markbakker78 wants to merge 5 commits intoshutterstock:mainfrom
Open
Added the possibility to add a minumum and maximum x value.#457markbakker78 wants to merge 5 commits intoshutterstock:mainfrom
markbakker78 wants to merge 5 commits intoshutterstock:mainfrom
Conversation
|
You might want to cleanup this pull request. Like removing the .idea folder from the pull request and correcting the indentation (rickshaw likes to used tabs) |
mustmodify
reviewed
Aug 24, 2018
rickshaw.js
Outdated
| graph.window.xMax = ui.values[1]; | ||
|
|
||
| console.log("graph.window.xMin: "+graph.window.xMin); | ||
| console.log("graph.window.xMax: "+graph.window.xMax); |
There was a problem hiding this comment.
In case they do get around to looking at this, might want to remove the console.log entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This to be able to show lots of graphs at one page with the same start and end time regardsless what the data has as first or last timestamp.