Don't override custom domain set on x/yScale option#399
Open
theefer wants to merge 1 commit intoshutterstock:mainfrom
Open
Don't override custom domain set on x/yScale option#399theefer wants to merge 1 commit intoshutterstock:mainfrom
theefer wants to merge 1 commit intoshutterstock:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm graphing data with sparse datapoints, but I want to fix the domain of the graph to match a given query, rather than discovering the domain based on the presence of data points.
For that, I had to use a custom
xScale. The current code overrides the domain and range of the customxScalethough, so this PR changes the code to only override the domain if it wasn't set externally.There might be a better way to do this, but that was the simplest I found. Feedback welcome!