[MRG] Add a separator between a criteria and other contents in a node in export_graphviz for visibility #22022
+95
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 17, 2021 21:42
… in node in dot file
takoika
commented
Dec 20, 2021
| "}" | ||
| ) | ||
|
|
||
| assert contents1 == contents2 |
Contributor
Author
There was a problem hiding this comment.
This filling missing assertion is not in a scope of this PR. So if this is not appropriate in the point of view of reviewing process, I will remove it from this PR and make a new PR for this fix.
added 3 commits
December 22, 2021 23:53
takoika
changed the title
takoika
changed the title
takoika
changed the title
added 3 commits
December 30, 2021 21:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #7774 . Add a separator line.
What does this implement/fix? Explain your changes.
Add a separator line between a criteria and other contents in node in
export_graphvizwhich increase visibility of exported tree. Precisely the PR introduced a new boolean parameteradd_separatortoexport_graphvizmethod. Whenadd_separatoris set as True, a separator line is added in an each node. This is achieved by using Record-based Nodes (see https://graphviz.org/doc/info/shapes.html#record).Any other comments?
A node shape becomes
recordnotboxwithadd_separator=True. This PR does not break backward compatibility becauseadd_separator=Falsein default.Obtained graphs are shown below.
add_separator=False(conventional)add_separator=True(new)"class_names":True, "filled":True, "leaves_parallel":True, "node_ids":True, "proportion":True, "rotate":True, "rounded":True, "add_separator":True, "special_characters":True}(separator with other parameters activated)