CLN Refactors find binning threshold #18395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
approved these changes
Sep 14, 2020
| @@ -16,76 +16,53 @@ | |||
| from .common import X_DTYPE, X_BINNED_DTYPE, ALMOST_INF | |||
|
|
|||
|
|
|||
| def _find_binning_thresholds(data, max_bins, subsample, random_state): | |||
| def _find_binning_threshold(col_data, max_bins): | |||
There was a problem hiding this comment.
I think this should still have an s:
Suggested change
| def _find_binning_threshold(col_data, max_bins): | |
| def _find_binning_thresholds(col_data, max_bins): |
ogrisel
approved these changes
Oct 14, 2020
| missing_mask = np.isnan(col_data) | ||
| if missing_mask.any(): | ||
| col_data = col_data[~missing_mask] | ||
| col_data = np.ascontiguousarray(col_data, dtype=X_DTYPE) |
There was a problem hiding this comment.
I think we have a problem if a column has 100% missing values. But this problem is already present in master.
amrcode
pushed a commit
to amrcode/scikit-learn
that referenced
this pull request
Oct 19, 2020
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related to #16909 and #18394
What does this implement/fix? Explain your changes.
This PR is used to make the above PRs easier to review.
CC @NicolasHug