chore: Add test to make sure flags are up to date and sorted #4845
+207
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemassa
requested review from
chenrui333,
nitrocode and
X-Guardian
and removed request for
a team
github-actions
bot
added
docs
jamengual
approved these changes
Aug 15, 2024
chenrui333
approved these changes
Aug 15, 2024
|
@lukemassa, can I get this merged? |
lukemassa
force-pushed
the
make_sure_documentation_flags_are_up_to_date
branch
from
8a72b59 to
2e87ffa
Compare
|
Hi @lukemassa, the tests and Website Link checks are failing on this PR |
|
This issue is stale because it has been open for 1 month with no activity. Remove stale label or comment or this will be closed in 1 month. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Add a unit test to make sure that the flags in the server-configuration.md page in the documentation match the configuration options, and are sorted in the file.
Additionally added documentation for two missing flags
--disable-global-apply-lockand--disable-markdown-folding, and reordered a few that were out of order.why
Important to make sure all our flags are documented (and the disabled flags are removed). Also might as well keep them sorted.
tests
Just running the unit tests
references
Followup from #4063