fix: filter out empty chunks in SentenceSplitter#1517
Open
parhammmm wants to merge 1 commit intorun-llama:mainfrom
Open
fix: filter out empty chunks in SentenceSplitter#1517parhammmm wants to merge 1 commit intorun-llama:mainfrom
parhammmm wants to merge 1 commit intorun-llama:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 764f0fb The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@parhammmm is attempting to deploy a commit to the LlamaIndex Team on Vercel. A member of the Team first needs to authorize it. |
@llamaindex/autotool
@llamaindex/cloud
@llamaindex/community
@llamaindex/core
@llamaindex/env
@llamaindex/experimental
llamaindex
@llamaindex/node-parser
@llamaindex/readers
@llamaindex/wasm-tools
@llamaindex/workflow
@llamaindex/anthropic
@llamaindex/clip
@llamaindex/deepinfra
@llamaindex/groq
@llamaindex/ollama
@llamaindex/huggingface
@llamaindex/openai
@llamaindex/portkey-ai
@llamaindex/replicate
@llamaindex/vllm
commit: |
himself65
suggested changes
Nov 22, 2024
Contributor
himself65
left a comment
himself65
left a comment
There was a problem hiding this comment.
could you please add test for this?
himself65
suggested changes
Dec 2, 2024
Contributor
himself65
left a comment
himself65
left a comment
There was a problem hiding this comment.
I didn't find the case then splits get empty, could you please add some tests
Contributor
Author
|
@himself65 this was the case where it happened https://gist.github.com/parhammmm/c69e37420c92cb85db788454f2a9fe27 It's a bit of an edge case and I found a way to work around it. Will need to find some time to figure out Llamaindex's test suite and then will add it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.