Skip to content

fix: align data layer with python side#1144

Open
himself65 wants to merge 15 commits intorun-llama:mainfrom
himself65:himself65/20240830/node
Open

fix: align data layer with python side#1144
himself65 wants to merge 15 commits intorun-llama:mainfrom
himself65:himself65/20240830/node

Conversation

@himself65
Copy link
Contributor

@himself65 himself65 commented Aug 30, 2024 •
edited
Loading

  • remove hash and type from toJSON
  • ObjectType value

@changeset-bot
Copy link

changeset-bot bot commented Aug 30, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: dc77d97

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Aug 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
llama-index-ts-docs ❌ Failed (Inspect) Sep 4, 2024 9:58pm

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 30, 2024 •
edited
Loading

Open in Stackblitz

@llamaindex/autotool

pnpm add https://pkg.pr.new/run-llama/LlamaIndexTS/@llamaindex/autotool@1144

@llamaindex/cloud

pnpm add https://pkg.pr.new/run-llama/LlamaIndexTS/@llamaindex/cloud@1144

@llamaindex/community

pnpm add https://pkg.pr.new/run-llama/LlamaIndexTS/@llamaindex/community@1144

@llamaindex/core

pnpm add https://pkg.pr.new/run-llama/LlamaIndexTS/@llamaindex/core@1144

@llamaindex/env

pnpm add https://pkg.pr.new/run-llama/LlamaIndexTS/@llamaindex/env@1144

@llamaindex/experimental

pnpm add https://pkg.pr.new/run-llama/LlamaIndexTS/@llamaindex/experimental@1144

@llamaindex/wasm-tools

pnpm add https://pkg.pr.new/run-llama/LlamaIndexTS/@llamaindex/wasm-tools@1144

llamaindex

pnpm add https://pkg.pr.new/run-llama/LlamaIndexTS/llamaindex@1144

commit: dc77d97

@himself65 himself65 changed the title feat: support convert from python side feat: improve convert from python side Aug 31, 2024
@himself65 himself65 changed the title feat: improve convert from python side fix: align data layer with python side Sep 3, 2024
@himself65 himself65 marked this pull request as ready for review September 3, 2024 22:25
@logan-markewich
Copy link
Contributor

logan-markewich commented Sep 3, 2024

@himself65 just checking, is this a breaking change for people that already have saved data?

@himself65
Copy link
Contributor Author

himself65 commented Sep 4, 2024

@himself65 just checking, is this a breaking change for people that already have saved data?

I think so, let me add backforward compability for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@himself65 @logan-markewich