feat(snowflake): support oauth authentication #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhar-rudder
requested review from
atzoum and
RanjeetMishra
as code owners
atzoum
reviewed
Nov 28, 2024
| @@ -34,11 +34,19 @@ type Config struct { | |||
| KeepSessionAlive bool `json:"keepSessionAlive"` | |||
| UseLegacyMappings bool `json:"useLegacyMappings"` | |||
| QueryTag string `json:"queryTag"` | |||
| Host string `json:"host"` | |||
| Token string `json:"token"` | |||
| Authenticator gosnowflake.AuthType `json:"authenticator"` | |||
There was a problem hiding this comment.
What other type of authenticators do we need to support? Would it be possible to run all scenarios for this new auth method here too?
There was a problem hiding this comment.
I just need support for oauth authentication. I can check if there is an API to generate oauth tokens
There was a problem hiding this comment.
Following the existing UseKeyPairAuth pattern, we could do the following for more predictable results:
UseOAuth bool
OAuthToken string
shekhar-rudder
force-pushed
the
pro-3896-sf-oauth
branch
from
881f49b
to
78e3a6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for oauth authentication is snowflake.
AuthenticatorisAuthTypeSnowflake. If the client provides its value, it will be overriddenHostandTokenfields in snowflake configLinear Ticket
< Replace_with_Linear_Link >
Security