Allow calls to GetOrganization if the org has public projects
#6174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaHegde
approved these changes
Nov 27, 2024
| @@ -933,12 +943,17 @@ func organizationToDTO(o *database.Organization) *adminv1.Organization { | |||
| OutstandingInvites: int32(o.QuotaOutstandingInvites), | |||
There was a problem hiding this comment.
Should quotas be privileged as well? It does expose what the plan the org could be on.
There was a problem hiding this comment.
We can do that – is the frontend able to handle quotas being empty for users who are not admins?
There was a problem hiding this comment.
Going to merge this as is, can do this in a follow up if it's worth it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.