code cleanup

rene-coty · May 25, 2023 · f38c0c2 · f38c0c2
1 parent 1321ddb
commit f38c0c2
Showing 1 changed file with 21 additions and 28 deletions.
diff --git a/src/providers/AppImageProvider.py b/src/providers/AppImageProvider.py
@@ -60,41 +60,34 @@ def __init__(self):
 
     def list_installed(self) -> List[AppImageListElement]:
         default_folder_path = self.get_appimages_default_destination_path()
+        desktop_files_dir = f'{GLib.get_user_data_dir()}/applications/'
         output = []
 
-        try:
-            folder = Gio.File.new_for_path(default_folder_path)
-            desktop_files_dir = f'{GLib.get_user_data_dir()}/applications/'
-
-            for file_name in os.listdir(desktop_files_dir):
-                gfile = Gio.File.new_for_path(desktop_files_dir + f'/{file_name}')
-
-                try:
-                    if get_giofile_content_type(gfile) == 'application/x-desktop':
+        for file_name in os.listdir(desktop_files_dir):
+            gfile = Gio.File.new_for_path(desktop_files_dir + f'/{file_name}')
 
-                        entry = DesktopEntry.DesktopEntry(filename=gfile.get_path())
-                        version = entry.get('X-AppImage-Version')
+            try:
+                if get_giofile_content_type(gfile) == 'application/x-desktop':
 
-                        if entry.getExec().startswith(default_folder_path) and GLib.file_test(entry.getExec(), GLib.FileTest.EXISTS):
-                            list_element = AppImageListElement(
-                                name=entry.getName(),
-                                description=entry.getComment(),
-                                icon=entry.getIcon(),
-                                app_id='',
-                                version=f"{entry.get('X-AppImage-Version')}",
-                                installed_status=InstalledStatus.INSTALLED,
-                                file_path=entry.getExec(),
-                                provider=self.name,
-                                desktop_entry=entry,
-                            )
+                    entry = DesktopEntry.DesktopEntry(filename=gfile.get_path())
 
-                            output.append(list_element)
+                    if entry.getExec().startswith(default_folder_path) and GLib.file_test(entry.getExec(), GLib.FileTest.EXISTS):
+                        list_element = AppImageListElement(
+                            name=entry.getName(),
+                            description=entry.getComment(),
+                            icon=entry.getIcon(),
+                            app_id='',
+                            version=f"{entry.get('X-AppImage-Version')}",
+                            installed_status=InstalledStatus.INSTALLED,
+                            file_path=entry.getExec(),
+                            provider=self.name,
+                            desktop_entry=entry,
+                        )
 
-                except Exception as e:
-                    logging.warn(e)
+                        output.append(list_element)
 
-        except Exception as e:
-            logging.error(e)
+            except Exception as e:
+                logging.warn(e)
 
         return output