Expose Scalar's constructor and Scalar#getScalarHandle() to public
#17580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nghia Truong <[email protected]>
ttnghia
added
3 - Ready for Review
|
/ok to test |
jlowe
approved these changes
Dec 11, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes the constructor and
getScalarHandle()method inScalar.javato the public, allowing them to be called from the outside. Without access to these methods, it was very inconvenient. Workaround has been implemented (spark-rapids-jni/CudfAccessor.java) to overcome this but it is better to have the issue addressed from the root.Partially contributes to NVIDIA/spark-rapids-jni#1307.