Enable all json reader options in pylibcudf read_json #17563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikeyann
added
2 - In Progress
github-actions
bot
added
Python
Matt711
reviewed
Dec 10, 2024
| @@ -198,6 +193,7 @@ def read_json( | |||
| mixed_types_as_string=mixed_types_as_string, | |||
| prune_columns=prune_columns, | |||
| recovery_mode=c_on_bad_lines, | |||
| extra_parameters=kwargs, | |||
There was a problem hiding this comment.
Just an FYI. I'm updating this API to use json reader options classes to match the other IO functions (eg. https://github.com/rapidsai/cudf/blob/branch-25.02/python/pylibcudf/pylibcudf/io/parquet.pyx#L309). So it will look like
plc.io.json.read_json(
plc.io.json.JsonReaderOptions.builder(
plc.io.SourceInfo(file_paths_or_buffers)
)
.byte_range_size(...)
...
)There was a problem hiding this comment.
These options will change because most of options are for spark, and they will change until all spark json feature requests are completed. These options are not intended for python users. It's exposed for quicker testing.
|
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR exposes all json reader options in pylibcudf and enables it via kwargs in
cudf.read_jsonsince kwargs cannot be used in cython, kwargs is passed as dict to cython.
These options are hidden in docs intentionally, as these options are mostly used for testing feature requests from spark json reader now. These options are expected to change.
Checklist