Skip to content

Commit

Permalink
Prefer docker compose over docker-compose to fix failing CI
Browse files Browse the repository at this point in the history
  • Loading branch information
ddimaria committed Aug 5, 2024
1 parent 5c7d808 commit 2756967
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions DEVELOPMENT.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ for more more information.

Docker Compose is a utility that's built into Docker Desktop and is a compact
infrastructure-as-code framework. Services (e.g. running Docker containers) are
defined, along with configuration information, in the `docker-compose.yml` file.
defined, along with configuration information, in the `docker compose.yml` file.
Services can talk to each other and can communicate with services in the user's host
network.

Expand All @@ -92,9 +92,9 @@ migrate the database. Docker is run in the background in this script.
To build images for individual services (from project root):

```shell
docker-compose build quadratic-api
docker-compose build quadratic-files
docker-compose build quadratic-multiplayer
docker compose build quadratic-api
docker compose build quadratic-files
docker compose build quadratic-multiplayer
```

### Developing without Docker
Expand Down
4 changes: 2 additions & 2 deletions quadratic-api/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
"prisma:migrate": "npx prisma migrate dev",
"prisma:migrate:create": "npx prisma migrate dev --create-only",
"prisma:dev:reset": "npx prisma migrate reset",
"docker:up": "docker-compose up -d && sleep 3",
"docker:down": "docker-compose down",
"docker:up": "docker compose up -d && sleep 3",
"docker:down": "docker compose down",
"docker:dev": "npm run docker:up && dotenv -e .env.test -- prisma migrate deploy && dotenv -e .env.test -- ts-node-dev --watch src --project ./tsconfig.json -- ./src/server.ts && npm run docker:down",
"docker:test:dev": "npm run docker:up && dotenv -e .env.test -- prisma migrate deploy && dotenv -e .env.test -- jest --watch --detectOpenHandles && npm run docker:down",
"docker:test:ci": "npm run docker:up && dotenv -e .env.test -- prisma migrate reset --force && dotenv -e .env.test -- jest --runInBand && npm run docker:down",
Expand Down
2 changes: 1 addition & 1 deletion quadratic-connection/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@
"coverage:html": "grcov . --binary-path ./target/debug/deps/ -s . -t html --branch --ignore-not-existing --ignore '../*' --ignore '/*' -o coverage/html",
"coverage:view": "open coverage/html/index.html",
"docker:up": "docker compose --profile quadratic-connection-test up -d && sleep 3",
"docker:down": "docker-compose down --profile quadratic-connection-test"
"docker:down": "docker compose down --profile quadratic-connection-test"
}
}
2 changes: 1 addition & 1 deletion quadratic-multiplayer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"coverage:gen": "CARGO_INCREMENTAL=0 RUSTFLAGS='-Cinstrument-coverage' LLVM_PROFILE_FILE='coverage/cargo-test-%p-%m.profraw' cargo test",
"coverage:html": "grcov . --binary-path ./target/debug/deps/ -s . -t html --branch --ignore-not-existing --ignore '../*' --ignore '/*' -o coverage/html",
"coverage:view": "open coverage/html/index.html",
"docker:up": "docker compose -f ../docker-compose.base.yml up -d --wait",
"docker:up": "docker compose -f ../docker compose.base.yml up -d --wait",
"docker:down": "docker compose down -v",
"docker:test": "docker compose kill && npm run docker:up && npm run test && npm run docker:down"
}
Expand Down

0 comments on commit 2756967

Please sign in to comment.