-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding doctrine costs configuration for redispatching, load shedding and losses #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: marifunf <[email protected]>
Signed-off-by: marifunf <[email protected]>
Signed-off-by: marifunf <[email protected]>
Signed-off-by: marifunf <[email protected]>
Signed-off-by: marifunf <[email protected]>
7 tasks
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
rolnico
requested changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Could you add:
- some javadoc on the different methods
generatorForAdequacy
,generatorForRedispatching
, etc. just to explain quickly what they are loading exactly - some documentation on ReadTheDoc (probably in
docs/mapping.md
but I'm not sure?)
Signed-off-by: marifunf <[email protected]>
Signed-off-by: marifunf <[email protected]>
rolnico
requested changes
Dec 17, 2024
Signed-off-by: marifunf <[email protected]>
Quality Gate passedIssues Measures |
Quality Gate passedIssues Measures |
rolnico
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Feature
What is the current behavior?
What is the new behavior (if this is a feature change)?
In existing generator('id') configuration function, redispatchingDownDoctrineCosts and redispatchingUpDoctrineCost can be defined
In existing load('id') configuration function, preventiveSheddingDoctrineCost and curativeSheddingDoctrineCost can be defined
A new losses() configuration function is added with costs attribute.
These new attributes are defined with a value or a time series name.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: