Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding doctrine costs configuration for redispatching, load shedding and losses #191

Merged
merged 11 commits into from
Dec 18, 2024

Conversation

marifunf
Copy link
Contributor

@marifunf marifunf commented Dec 13, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Feature

What is the current behavior?

What is the new behavior (if this is a feature change)?
In existing generator('id') configuration function, redispatchingDownDoctrineCosts and redispatchingUpDoctrineCost can be defined

In existing load('id') configuration function, preventiveSheddingDoctrineCost and curativeSheddingDoctrineCost can be defined

A new losses() configuration function is added with costs attribute.

These new attributes are defined with a value or a time series name.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Copy link
Member

@rolnico rolnico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
Could you add:

  • some javadoc on the different methods generatorForAdequacy, generatorForRedispatching, etc. just to explain quickly what they are loading exactly
  • some documentation on ReadTheDoc (probably in docs/mapping.md but I'm not sure?)

docs/metrix.md Outdated Show resolved Hide resolved
docs/metrix.md Show resolved Hide resolved
docs/metrix.md Show resolved Hide resolved
@rolnico rolnico merged commit 9e00ea2 into main Dec 18, 2024
13 checks passed
@rolnico rolnico deleted the MFU/IMG-2475 branch December 18, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants