Fix CentOS CI by using docker #190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
|
|
olperr1
requested changes
Dec 13, 2024
Comment on lines
+43
to
+44
| #RUN wget --max-redirect=0 https://github.com/openssl/openssl/releases/download/OpenSSL_1_1_1w/openssl-${OPENSSL_VERSION}.tar.gz \ | ||
| # && tar -xzf openssl-${OPENSSL_VERSION}.tar.gz |
There was a problem hiding this comment.
Can you remove the commented instructions?
Also in "Python" and "Boost" sections.
| && ln -sf /usr/local/bin/pip3.10 /usr/bin/pip3 \ | ||
| && python3 -V \ | ||
| && python3 -c "import ssl; print(ssl.OPENSSL_VERSION)" \ | ||
| && pip3 install cmake==${CMAKE_VERSION} \ |
There was a problem hiding this comment.
It seems to be working but there is an error in the build execution:
No such file or directory: '/usr/local/bin/pip3'
(But it's only for a logging problem, I think)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix / Feature
What is the current behavior?
CI doesn't work anymore on CentOS due to EOL of the OS and deprecation of the NodeJS version used
What is the new behavior (if this is a feature change)?
CI is done on a docker image of centos and it works
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: