Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(openapi-react-query): support for useInfiniteQuery() #1881

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(openapi-react-query): support for useInfiniteQuery() #1881

wants to merge 3 commits into from
+190 −1

Conversation

jungwoo3490
Copy link

@jungwoo3490 jungwoo3490 commented Aug 27, 2024 •
edited
Loading

Changes

close #1828

I added useInfiniteQuery() to openapi-react-query.

How to Review

Any feedback is welcome. I'll review it and make updates!

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

@jungwoo3490 jungwoo3490 requested a review from a team as a code owner August 27, 2024 20:39
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 27, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: ba441ca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jungwoo3490 jungwoo3490 changed the title feat(openapi-react-query): support for useInfinityQuery() feat(openapi-react-query): support for useInfiniteQuery() Sep 1, 2024
@jungwoo3490
Copy link
Author

@drwpow @kerwanp
Can you check this PR? 👀

@drwpow drwpow added the openapi-react-query Relevant to openapi-react-query label Oct 25, 2024
@tommymarshall
Copy link

Is there any reason not to introduce this?

@kerwanp
Copy link
Contributor

kerwanp commented Nov 15, 2024

@tommymarshall @jungwoo3490 this pull request does not seem to be ready to be merged as tests are still failing. And with the latest changes it now has conflicts with main branch.

I would be happy to review a pull request introducing those changes with successful tests and resolved conflicts.

@tommymarshall
Copy link

@tommymarshall @jungwoo3490 this pull request does not seem to be ready to be merged as tests are still failing. And with the latest changes it now has conflicts with main branch.

I would be happy to review a pull request introducing those changes with successful tests and resolved conflicts.

Looks like it it's a build error with existing code -- worth re-running or getting the branch up-to-date @jungwoo3490 ?

@jungwoo3490
Copy link
Author

@kerwanp @tommymarshall
I'll update my branch and resolve the conflict as soon as possible!

@Mattias-
Copy link

Thank you for helping out @jungwoo3490!
It would be a nice feature to have.

@jungwoo3490 jungwoo3490 force-pushed the feat/useInfiniteQuery branch from da3a024 to 5b61eea Compare December 14, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
openapi-react-query Relevant to openapi-react-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

openapi-react-query: support for useInfiniteQuery()
5 participants
@jungwoo3490 @tommymarshall @kerwanp @Mattias- @drwpow