Guess the used content type when multiple content is defined #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is a follow up of the workaround merged in this PR #1597
Here the point is to infer the content type from the
Acceptheader on each request.For now I'm stuck, in the
ClientMethodtype, I did not succeed to infer the type. TheI extends MaybeOptionalInit<Paths[P], M, AcceptHeader>,seems to prevent the inference. Did someone have an idea?When this works, I still need to add a branch on the
ParseAsResponseto manage the content type only onparseAs: jsonChecklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)