Fix a compile error with Clang on Windows in Release build #18552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Markus Prettner <[email protected]>
spham-amzn
reviewed
Dec 13, 2024
| @@ -29,7 +29,7 @@ namespace AzQtComponents | |||
|
|
|||
| namespace | |||
| { | |||
| std::string GetLastErrorString() | |||
| [[maybe_unused]] std::string GetLastErrorString() | |||
There was a problem hiding this comment.
This is fine, but you can squeeze a little bit more build optimization be wrapping this function inside a #if defined(AZ_ENABLE_TRACING) block. This is based on this function only existing inside the AZ_Asserts in this method.
spham-amzn
approved these changes
Dec 13, 2024
DrogonMar
pushed a commit
to DrogonMar/o3de
that referenced
this pull request
Dec 20, 2024
Signed-off-by: Markus Prettner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a compile error that occurs when compiling the engine with Clang on Windows in a release build. The locally defined function
GetLastErrorString()is only used as parameter toAZ_Assert, meaning it is not called in release builds, which leads to a unused function warning.How was this PR tested?
Compile with Clang on Windows with Release configuration