Vulkan RHI: Don't expose HDR surface format when SetHDRMetadata is null #18547
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible on KDE at least that when you use HDR you do expose the format VK_FORMAT_A2R10G10B10_UNORM_PACK32 but don't have the Vulkan extension needed to set HDR metadata. Wayland HDR as of 12/2024 is experimental. Signed-off-by: Reece Hagan <[email protected]>
moudgils
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the common
R10G10B10A2_PACK32format from supported surface formats when SetHDRMetadata is null.When using KDE with Wayland and enabling HDR on your monitor the engine will select the
R10G10B10A2_PACK32which ends up looking grey and dim due to no SetHDRMetadata support in the VK RHI, this fixes that and gives you a proper SDR image.How was this PR tested?
I used the wayland branch on my fork with this setup:
I also tested with XCB just to make sure.