Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 3P version and SHA256 hash for assimp-5.4.3 #18545

Closed
wants to merge 1 commit into from
Closed

Update 3P version and SHA256 hash for assimp-5.4.3 #18545

wants to merge 1 commit into from

Conversation

o3de-issues-bot
Copy link
Contributor

Automated PR to update 3P version and SHA256 for assimp-5.4.3

amzn-changml
amzn-changml requested changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@amzn-changml amzn-changml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging blocked until this is promoted to production: https://github.com/o3de/3p-package-source/actions/runs/12242049712

AMZN-Gene
AMZN-Gene approved these changes Dec 9, 2024
View reviewed changes
cmake/3rdParty/Platform/Linux/BuiltInPackages_linux_aarch64.cmake
@@ -17,7 +17,7 @@ ly_associate_package(PACKAGE_NAME xxhash-0.7.4-rev1-multiplatform

# platform-specific:
ly_associate_package(PACKAGE_NAME expat-2.4.2-rev2-linux-aarch64 TARGETS expat PACKAGE_HASH 934a535c1492d11906789d7ddf105b1a530cf8d8fb126063ffde16c5caeb0179)
ly_associate_package(PACKAGE_NAME assimp-5.4.3-rev1-linux-aarch64 TARGETS assimplib PACKAGE_HASH 6f3882d9c17071f5014667aff868bd9f5b899fe67f51180bbb2e7137c2bf49c2)
ly_associate_package(PACKAGE_NAME assimp-5.4.3-rev2-linux-aarch64 TARGETS assimp PACKAGE_HASH c74254dedabaf169c66d575fc9851f0f288ac024c3d2359795c284de792c9dca)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ly_associate_package(PACKAGE_NAME assimp-5.4.3-rev2-linux-aarch64 TARGETS assimp PACKAGE_HASH c74254dedabaf169c66d575fc9851f0f288ac024c3d2359795c284de792c9dca)
ly_associate_package(PACKAGE_NAME assimp-5.4.3-rev2-linux-aarch64 TARGETS assimplib PACKAGE_HASH c74254dedabaf169c66d575fc9851f0f288ac024c3d2359795c284de792c9dca)

cmake/3rdParty/Platform/Linux/BuiltInPackages_linux_x86_64.cmake
@@ -18,7 +18,7 @@ ly_associate_package(PACKAGE_NAME cityhash-1.1-multiplatform

# platform-specific:
ly_associate_package(PACKAGE_NAME expat-2.4.2-rev2-linux TARGETS expat PACKAGE_HASH 755369a919e744b9b3f835d1acc684f02e43987832ad4a1c0b6bbf884e6cd45b)
ly_associate_package(PACKAGE_NAME assimp-5.4.3-rev1-linux TARGETS assimplib PACKAGE_HASH 6d48c4fc4c41d53562bd9c2d021f27cce387c31fc2c6110ff5572128d49ea7ce)
ly_associate_package(PACKAGE_NAME assimp-5.4.3-rev2-linux TARGETS assimp PACKAGE_HASH 974865c8945ce5aa36a9dd44631c34ba213c69b5c536fb00250333a4236e7e87)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ly_associate_package(PACKAGE_NAME assimp-5.4.3-rev2-linux TARGETS assimp PACKAGE_HASH 974865c8945ce5aa36a9dd44631c34ba213c69b5c536fb00250333a4236e7e87)
ly_associate_package(PACKAGE_NAME assimp-5.4.3-rev2-linux TARGETS assimplib PACKAGE_HASH 974865c8945ce5aa36a9dd44631c34ba213c69b5c536fb00250333a4236e7e87)

cmake/3rdParty/Platform/Mac/BuiltInPackages_mac.cmake
@@ -19,7 +19,7 @@ ly_associate_package(PACKAGE_NAME xxhash-0.7.4-rev1-multiplatform

# platform-specific:
ly_associate_package(PACKAGE_NAME expat-2.4.2-rev2-mac TARGETS expat PACKAGE_HASH 70f195977a17b08a4dc8687400fd7f2589e3b414d4961b562129166965b6f658)
ly_associate_package(PACKAGE_NAME assimp-5.4.3-rev1-mac TARGETS assimplib PACKAGE_HASH 2e3eaf23990888e1386328d3d42d99d65bff4c94d385889406f314952608062b)
ly_associate_package(PACKAGE_NAME assimp-5.4.3-rev2-mac TARGETS assimp PACKAGE_HASH 3fe92bff7f1d9322d445c3be775a5be84f2cee2e1c617192e62f1545691c957e)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ly_associate_package(PACKAGE_NAME assimp-5.4.3-rev2-mac TARGETS assimp PACKAGE_HASH 3fe92bff7f1d9322d445c3be775a5be84f2cee2e1c617192e62f1545691c957e)
ly_associate_package(PACKAGE_NAME assimp-5.4.3-rev2-mac TARGETS assimplib PACKAGE_HASH 3fe92bff7f1d9322d445c3be775a5be84f2cee2e1c617192e62f1545691c957e)

cmake/3rdParty/Platform/Windows/BuiltInPackages_windows.cmake
@@ -19,7 +19,7 @@ ly_associate_package(PACKAGE_NAME xxhash-0.7.4-rev1-multiplatform

# platform-specific:
ly_associate_package(PACKAGE_NAME expat-2.4.2-rev2-windows TARGETS expat PACKAGE_HASH 748d08f21f5339757059a7887e72b52d15e954c549245c638b0b05bd5961e307)
ly_associate_package(PACKAGE_NAME assimp-5.4.3-rev1-windows TARGETS assimplib PACKAGE_HASH 3142a3868fe3a5a92b5d1395b47e4faf758b7ca3feb3fa96d394dae44695c809)
ly_associate_package(PACKAGE_NAME assimp-5.4.3-rev2-windows TARGETS assimp PACKAGE_HASH b95d162fa018534b95a82dce0df6a075d47bcfa34548a368c8cdbf9c4d70826d)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ly_associate_package(PACKAGE_NAME assimp-5.4.3-rev2-windows TARGETS assimp PACKAGE_HASH b95d162fa018534b95a82dce0df6a075d47bcfa34548a368c8cdbf9c4d70826d)
ly_associate_package(PACKAGE_NAME assimp-5.4.3-rev2-windows TARGETS assimplib PACKAGE_HASH b95d162fa018534b95a82dce0df6a075d47bcfa34548a368c8cdbf9c4d70826d)

@AMZN-Gene
Copy link
Contributor

Anyone know why O3DE is looking for assimplib instead of assimp?

@AMZN-Gene
Copy link
Contributor

AMZN-Gene commented Dec 10, 2024 •
edited
Loading

Tested a naming fix locally and it works!
Approve this PR and then we won't need to hand-edit the 3rd party package bot PRs in the future. Close this PR and regenerate a new bot PR.

@byrcolin byrcolin added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Dec 10, 2024
@AMZN-Gene AMZN-Gene closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amzn-changml amzn-changml amzn-changml requested changes

@AMZN-Gene AMZN-Gene AMZN-Gene approved these changes

Assignees
No one assigned
Labels
needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@o3de-issues-bot @AMZN-Gene @amzn-changml @byrcolin