Handle multiGPU Passes in ImGui Timestamp View #18500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinwinter-huawei
force-pushed
the
gpuprofiler_multigpu
branch
2 times, most recently
from
cc913cc to
e609b9d
Compare
martinwinter-huawei
changed the title
martinwinter-huawei
force-pushed
the
gpuprofiler_multigpu
branch
from
e609b9d to
9fcfaaa
Compare
Signed-off-by: Martin Winter <[email protected]>
martinwinter-huawei
force-pushed
the
gpuprofiler_multigpu
branch
from
9fcfaaa to
ea5ae3e
Compare
byrcolin
added
the
needs-sig
jhmueller-huawei
added
sig/graphics-audio
jhmueller-huawei
approved these changes
Dec 4, 2024
|
@manon-traverse FYI. |
galibzon
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR improves the handling of multi-GPU passes in the GPU Profiler -> TimestampView.
It does the following:
One remaining issue is that multiple timelines are drawn and scaled independently at the moment.
Since there currently is no way to match/synchronize timestamps between devices, each GPU scales its own timeline to the full length of the window, instead of scaling all passes the same and shifting them along as needed.
This would require something like calibrated timestamps to handle better.
In the meantime, timelines are internally consistent but cannot be directly compared with one another.
How was this PR tested?
Tested with the MultiGPU RPI sample in ASV.