Fix: add if check to remove left project buttons when projects.isEmpty() #18465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrcolin
added
the
needs-sig
Signed-off-by: devldm <[email protected]>
spham-amzn
added
sig/content
lsemp3d
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR aims to fix a bug with projects not been removed from the UI when they are deleted (when just 1 project is left)
Old behaviour
This bug is is described here but essentially if only 1 project was left and the user deleted it. It
New behaviour
Now if just 1 project remains and the user deletes it, it is removed from the UI as expected.
Screencast.from.2024-11-13.10-47-14.mp4
How was this PR tested?
Tested locally (manually) in a profile build
OS: Debian 12 (bookworm)