refactor: Remove InMemory Storage Provider

linkdotnet · Oct 11, 2024 · 35a851e · 35a851e
1 parent 5acfddc
commit 35a851e
Show file tree

Hide file tree

Showing 14 changed files with 122 additions and 405 deletions.
diff --git a/docs/Setup/Configuration.md b/docs/Setup/Configuration.md
diff --git a/docs/Storage/Readme.md b/docs/Storage/Readme.md
@@ -2,13 +2,21 @@
 
 Currently, there are 5 Storage-Provider:
 
--   InMemory - Basically a list holding your data (per request). If the User hits a hard reload, the data is gone.
 -   RavenDb - As the name suggests for RavenDb. RavenDb automatically creates all the documents, if a database name is provided.
+-   MongoDB - Based on the official MongoDB driver. The database and collection are automatically created.
 -   Sqlite - Based on EF Core, it can be easily adapted for other Sql Dialects. The tables are automatically created.
 -   SqlServer - Based on EF Core, it can be easily adapted for other Sql Dialects. The tables are automatically created.
 -   MySql - Based on EF Core - also supports MariaDB.
 
-The default (when you clone the repository) is the `InMemory` option. That means every time you restart the service, all posts and related objects are gone.
+The default (when you clone the repository) is the `Sqlite` option with an in-memory database.
+That means every time you restart the service, all posts and related objects are gone. This is useful for testing. 
+If you want to persist the data with Sqlite, you can change the `appsettings.json` file to:
+
+```json
+{
+	"PersistenceProvider": "Sqlite",
+	"ConnectionString": "Data Source=blog.db",
+```
 
 Note the ConnectionString format of SQL Server needs to be consistent:
 

diff --git a/src/LinkDotNet.Blog.Infrastructure/Persistence/InMemory/PaginatedListQueryExtensions.cs b/src/LinkDotNet.Blog.Infrastructure/Persistence/InMemory/PaginatedListQueryExtensions.cs
diff --git a/src/LinkDotNet.Blog.Infrastructure/Persistence/InMemory/Repository.cs b/src/LinkDotNet.Blog.Infrastructure/Persistence/InMemory/Repository.cs
diff --git a/src/LinkDotNet.Blog.Infrastructure/Persistence/PersistenceProvider.cs b/src/LinkDotNet.Blog.Infrastructure/Persistence/PersistenceProvider.cs
@@ -7,7 +7,6 @@ public sealed class PersistenceProvider : Enumeration<PersistenceProvider>
     public static readonly PersistenceProvider SqlServer = new(nameof(SqlServer));
     public static readonly PersistenceProvider Sqlite = new(nameof(Sqlite));
     public static readonly PersistenceProvider RavenDb = new(nameof(RavenDb));
-    public static readonly PersistenceProvider InMemory = new(nameof(InMemory));
     public static readonly PersistenceProvider MySql = new(nameof(MySql));
     public static readonly PersistenceProvider MongoDB = new(nameof(MongoDB));
 

diff --git a/src/LinkDotNet.Blog.Web/RegistrationExtensions/InMemoryRegistrationExtensions.cs b/src/LinkDotNet.Blog.Web/RegistrationExtensions/InMemoryRegistrationExtensions.cs
diff --git a/src/LinkDotNet.Blog.Web/RegistrationExtensions/StorageProviderExtensions.cs b/src/LinkDotNet.Blog.Web/RegistrationExtensions/StorageProviderExtensions.cs
@@ -18,12 +18,7 @@ public static IServiceCollection AddStorageProvider(this IServiceCollection serv
         var provider = configuration["PersistenceProvider"] ?? throw new InvalidOperationException("No persistence provider configured");
         var persistenceProvider = PersistenceProvider.Create(provider);
 
-        if (persistenceProvider == PersistenceProvider.InMemory)
-        {
-            services.UseInMemoryAsStorageProvider();
-            services.RegisterCachedRepository<Infrastructure.Persistence.InMemory.Repository<BlogPost>>();
-        }
-        else if (persistenceProvider == PersistenceProvider.RavenDb)
+        if (persistenceProvider == PersistenceProvider.RavenDb)
         {
             services.UseRavenDbAsStorageProvider();
             services.RegisterCachedRepository<Infrastructure.Persistence.RavenDb.Repository<BlogPost>>();

diff --git a/src/LinkDotNet.Blog.Web/appsettings.json b/src/LinkDotNet.Blog.Web/appsettings.json
@@ -19,8 +19,8 @@
 		"BackgroundUrl": "assets/profile-background.webp",
 		"ProfilePictureUrl": "assets/profile-picture.webp"
 	},
-	"PersistenceProvider": "InMemory",
-	"ConnectionString": "",
+	"PersistenceProvider": "Sqlite",
+	"ConnectionString": "DataSource=file::memory:?cache=shared",
 	"DatabaseName": "",
 	"Authentication": {
 		"Provider": "Auth0",

diff --git a/tests/LinkDotNet.Blog.IntegrationTests/SmokeTests.cs b/tests/LinkDotNet.Blog.IntegrationTests/SmokeTests.cs
@@ -15,7 +15,8 @@ public SmokeTests(WebApplicationFactory<Program> factory)
     {
         this.factory = factory.WithWebHostBuilder(builder =>
         {
-            builder.UseSetting("PersistenceProvider", PersistenceProvider.InMemory.Key);
+            builder.UseSetting("PersistenceProvider", PersistenceProvider.Sqlite.Key);
+            builder.UseSetting("ConnectionString", "DataSource=file::memory:?cache=shared");
         });
     }