fix: Don't apply title multiple times (Fixes #385)

linkdotnet · Nov 30, 2024 · 28fb2ef · 28fb2ef
1 parent 36f683b
commit 28fb2ef
Show file tree

Hide file tree

Showing 28 changed files with 64 additions and 57 deletions.
diff --git a/src/LinkDotNet.Blog.Web/ApplicationConfiguration.cs b/src/LinkDotNet.Blog.Web/ApplicationConfiguration.cs
@@ -1,5 +1,3 @@
-using System.ComponentModel.DataAnnotations;
-
 namespace LinkDotNet.Blog.Web;
 
 public sealed record ApplicationConfiguration

diff --git a/src/LinkDotNet.Blog.Web/ConfigurationExtension.cs b/src/LinkDotNet.Blog.Web/ConfigurationExtension.cs
@@ -6,7 +6,6 @@
 using LinkDotNet.Blog.Web.Features.SupportMe.Components;
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
-using Microsoft.Extensions.Options;
 
 namespace LinkDotNet.Blog.Web;
 

diff --git a/src/LinkDotNet.Blog.Web/Features/Admin/BlogPostEditor/Components/CreateNewBlogPost.razor b/src/LinkDotNet.Blog.Web/Features/Admin/BlogPostEditor/Components/CreateNewBlogPost.razor
@@ -2,7 +2,6 @@
 @using LinkDotNet.Blog.Infrastructure
 @using LinkDotNet.Blog.Infrastructure.Persistence
 @using LinkDotNet.Blog.Web.Features.Services
-@using LinkDotNet.Blog.Web.Features.ShowBlogPost.Components
 @using NCronJob
 @inject IJSRuntime JSRuntime
 @inject ICacheInvalidator CacheInvalidator
@@ -136,7 +135,7 @@
 
     private string? originalContent = null;
     private bool IsContentConverted => !string.IsNullOrWhiteSpace(originalContent);
-    private string ConvertLabel => !IsContentConverted ? "Convert to markdown" : "Restore"; 
+    private string ConvertLabel => !IsContentConverted ? "Convert to markdown" : "Restore";
 
     private bool canSubmit = true;
     private IPagedList<ShortCode> shortCodes = PagedList<ShortCode>.Empty;

diff --git a/src/LinkDotNet.Blog.Web/Features/Home/Index.razor b/src/LinkDotNet.Blog.Web/Features/Home/Index.razor
@@ -15,6 +15,8 @@
 @inject IOptions<ApplicationConfiguration> AppConfiguration
 @inject NavigationManager NavigationManager
 
+<PageTitle>@AppConfiguration.Value.BlogName</PageTitle>
+
 <OgData Title="@(Markdown.ToPlainText(AppConfiguration.Value.BlogName))"
         AbsolutePreviewImageUrl="@ImageUrl"
         Description="@(Markdown.ToPlainText(Introduction.Value.Description))"></OgData>

diff --git a/src/LinkDotNet.Blog.Web/Features/MarkdownConverter.cs b/src/LinkDotNet.Blog.Web/Features/MarkdownConverter.cs
@@ -7,7 +7,6 @@
 using Markdig.Syntax;
 using Markdig.Syntax.Inlines;
 using Microsoft.AspNetCore.Components;
-using MongoDB.Driver.Linq;
 
 namespace LinkDotNet.Blog.Web.Features;
 

diff --git a/src/LinkDotNet.Blog.Web/Pages/_Layout.cshtml b/src/LinkDotNet.Blog.Web/Pages/_Layout.cshtml
@@ -9,7 +9,6 @@
 <head>
     <meta charset="utf-8"/>
     <meta name="viewport" content="width=device-width, initial-scale=1.0"/>
-    <title>@AppConfiguration.Value.BlogName</title>
     <base href="~/"/>
     <link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png"/>
     <link rel="icon" type="image/png" sizes="32x32" href="/favicon-32x32.png"/>

diff --git a/tests/LinkDotNet.Blog.IntegrationTests/SmokeTests.cs b/tests/LinkDotNet.Blog.IntegrationTests/SmokeTests.cs
@@ -1,45 +1,42 @@
 using System;
+using System.Linq;
+using System.Net.Http;
 using System.Threading.Tasks;
+using AngleSharp.Html.Dom;
+using AngleSharp.Html.Parser;
 using LinkDotNet.Blog.Infrastructure.Persistence;
+using LinkDotNet.Blog.Infrastructure.Persistence.Sql;
+using LinkDotNet.Blog.TestUtilities;
 using LinkDotNet.Blog.Web;
 using Microsoft.AspNetCore.Mvc.Testing;
+using Microsoft.EntityFrameworkCore;
+using Microsoft.Extensions.DependencyInjection;
 using TestContext = Xunit.TestContext;
 
 namespace LinkDotNet.Blog.IntegrationTests;
 
 public sealed class SmokeTests : IClassFixture<WebApplicationFactory<Program>>, IDisposable, IAsyncDisposable
 {
     private readonly WebApplicationFactory<Program> factory;
+    private readonly IServiceScope scope;
+    private readonly HttpClient client;
 
     public SmokeTests(WebApplicationFactory<Program> factory)
     {
         this.factory = factory.WithWebHostBuilder(builder =>
         {
+            builder.UseSetting("BlogName", "Tests Title");
             builder.UseSetting("PersistenceProvider", PersistenceProvider.Sqlite.Key);
             builder.UseSetting("ConnectionString", "DataSource=file::memory:?cache=shared");
         });
+
+        scope = this.factory.Services.CreateScope();
+        client = this.factory.CreateClient();
     }
 
     [Fact]
     public async Task ShouldBootUpApplication()
     {
-        using var client = factory.CreateClient();
-
-        var result = await client.GetAsync("/", cancellationToken: TestContext.Current.CancellationToken);
-
-        result.IsSuccessStatusCode.ShouldBeTrue();
-    }
-
-    [Fact]
-    public async Task ShouldBootUpWithSqlDatabase()
-    {
-        await using var sqlFactory = factory.WithWebHostBuilder(builder =>
-        {
-            builder.UseSetting("PersistenceProvider", PersistenceProvider.Sqlite.Key);
-            builder.UseSetting("ConnectionString", "DataSource=file::memory:?cache=shared");
-        });
-        using var client = sqlFactory.CreateClient();
-
         var result = await client.GetAsync("/", cancellationToken: TestContext.Current.CancellationToken);
 
         result.IsSuccessStatusCode.ShouldBeTrue();
@@ -48,8 +45,6 @@ public async Task ShouldBootUpWithSqlDatabase()
     [Fact]
     public async Task ShouldAllowDotsForTagSearch()
     {
-        using var client = factory.CreateClient();
-
         var result = await client.GetAsync("/searchByTag/.NET5", cancellationToken: TestContext.Current.CancellationToken);
 
         result.IsSuccessStatusCode.ShouldBeTrue();
@@ -58,8 +53,6 @@ public async Task ShouldAllowDotsForTagSearch()
     [Fact]
     public async Task ShouldAllowDotsForFreeTextSearch()
     {
-        using var client = factory.CreateClient();
-
         var result = await client.GetAsync("/search/.NET5", cancellationToken: TestContext.Current.CancellationToken);
 
         result.IsSuccessStatusCode.ShouldBeTrue();
@@ -69,7 +62,6 @@ public async Task ShouldAllowDotsForFreeTextSearch()
     public async Task RssFeedShouldBeRateLimited()
     {
         const int numberOfRequests = 16;
-        using var client = factory.CreateClient();
 
         for (var i = 0; i < numberOfRequests - 1; i++)
         {
@@ -81,10 +73,55 @@ public async Task RssFeedShouldBeRateLimited()
         lastResult.IsSuccessStatusCode.ShouldBeFalse();
     }
 
-    public void Dispose() => factory?.Dispose();
+    [Fact]
+    public async Task ShowingBlogPost_ShouldOnlyHaveOneTitle()
+    {
+        var blogPost = new BlogPostBuilder().WithTitle("My Blog Post").Build();
+        var contextProvider = scope.ServiceProvider.GetRequiredService<IDbContextFactory<BlogDbContext>>();
+        await using var context = await contextProvider.CreateDbContextAsync(TestContext.Current.CancellationToken);
+        await context.BlogPosts.AddAsync(blogPost, TestContext.Current.CancellationToken);
+        await context.SaveChangesAsync(TestContext.Current.CancellationToken);
+
+        var result = await client.GetAsync($"/blogPost/{blogPost.Id}", cancellationToken: TestContext.Current.CancellationToken);
+
+        result.IsSuccessStatusCode.ShouldBeTrue();
+        var content = await result.Content.ReadAsStringAsync(TestContext.Current.CancellationToken);
+        var document = GetHtmlDocument(content);
+        var titleTags = document.QuerySelectorAll("title");
+        titleTags.Length.ShouldBe(1);
+        titleTags.Single().TextContent.ShouldBe("My Blog Post");
+    }
+
+    [Fact]
+    public async Task IndexPage_HasTitleFromConfiguration()
+    {
+        var result = await client.GetAsync("/", cancellationToken: TestContext.Current.CancellationToken);
+
+        result.IsSuccessStatusCode.ShouldBeTrue();
+        var content = await result.Content.ReadAsStringAsync(TestContext.Current.CancellationToken);
+        var document = GetHtmlDocument(content);
+        var titleTags = document.QuerySelectorAll("title");
+        titleTags.Length.ShouldBe(1);
+        titleTags.Single().TextContent.ShouldBe("Tests Title");
+    }
+
+    public void Dispose()
+    {
+        scope.Dispose();
+        client.Dispose();
+        factory?.Dispose();
+    }
 
     public async ValueTask DisposeAsync()
     {
+        scope.Dispose();
+        client.Dispose();
         await factory.DisposeAsync();
     }
+
+    private static IHtmlDocument GetHtmlDocument(string html)
+    {
+        var parser = new HtmlParser();
+        return parser.ParseDocument(html);
+    }
 }
diff --git a/tests/LinkDotNet.Blog.IntegrationTests/Web/Features/Admin/ShortCodes/ShortCodesPageTests.cs b/tests/LinkDotNet.Blog.IntegrationTests/Web/Features/Admin/ShortCodes/ShortCodesPageTests.cs
@@ -1,6 +1,5 @@
 using System.Linq;
 using System.Threading.Tasks;
-using AngleSharp.Html.Dom;
 using Blazored.Toast.Services;
 using LinkDotNet.Blog.Domain;
 using LinkDotNet.Blog.TestUtilities.Fakes;

diff --git a/...Blog.IntegrationTests/Web/Features/ShowBlogPost/Components/SimilarBlogPostSectionTests.cs b/...Blog.IntegrationTests/Web/Features/ShowBlogPost/Components/SimilarBlogPostSectionTests.cs
@@ -1,4 +1,3 @@
-using System.Collections.Generic;
 using System.Threading.Tasks;
 using LinkDotNet.Blog.Domain;
 using LinkDotNet.Blog.Infrastructure.Persistence;

diff --git a/tests/LinkDotNet.Blog.IntegrationTests/Web/Features/ShowBlogPost/ShowBlogPostPageTests.cs b/tests/LinkDotNet.Blog.IntegrationTests/Web/Features/ShowBlogPost/ShowBlogPostPageTests.cs
@@ -1,11 +1,9 @@
-using System.Collections.Generic;
-using System.Threading.Tasks;
+using System.Threading.Tasks;
 using Blazored.Toast.Services;
 using LinkDotNet.Blog.Domain;
 using LinkDotNet.Blog.Infrastructure;
 using LinkDotNet.Blog.Infrastructure.Persistence;
 using LinkDotNet.Blog.TestUtilities;
-using LinkDotNet.Blog.Web;
 using LinkDotNet.Blog.Web.Features.Components;
 using LinkDotNet.Blog.Web.Features.Services;
 using LinkDotNet.Blog.Web.Features.ShowBlogPost;

diff --git a/tests/LinkDotNet.Blog.IntegrationTests/Web/Features/SimilarBlogPostJobTests.cs b/tests/LinkDotNet.Blog.IntegrationTests/Web/Features/SimilarBlogPostJobTests.cs
@@ -3,7 +3,6 @@
 using LinkDotNet.Blog.Domain;
 using LinkDotNet.Blog.Infrastructure.Persistence.Sql;
 using LinkDotNet.Blog.TestUtilities;
-using LinkDotNet.Blog.Web;
 using LinkDotNet.Blog.Web.Features;
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Options;

diff --git a/...et.Blog.IntegrationTests/Web/RegistrationExtensions/RavenDbRegistrationExtensionsTests.cs b/...et.Blog.IntegrationTests/Web/RegistrationExtensions/RavenDbRegistrationExtensionsTests.cs
@@ -1,7 +1,6 @@
 using LinkDotNet.Blog.Domain;
 using LinkDotNet.Blog.Infrastructure.Persistence;
 using LinkDotNet.Blog.TestUtilities;
-using LinkDotNet.Blog.Web;
 using LinkDotNet.Blog.Web.RegistrationExtensions;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Options;

diff --git a/...Net.Blog.IntegrationTests/Web/RegistrationExtensions/SqliteRegistrationExtensionsTests.cs b/...Net.Blog.IntegrationTests/Web/RegistrationExtensions/SqliteRegistrationExtensionsTests.cs
@@ -1,7 +1,6 @@
 using LinkDotNet.Blog.Domain;
 using LinkDotNet.Blog.Infrastructure.Persistence;
 using LinkDotNet.Blog.TestUtilities;
-using LinkDotNet.Blog.Web;
 using LinkDotNet.Blog.Web.RegistrationExtensions;
 using Microsoft.Extensions.Options;
 using Microsoft.Extensions.DependencyInjection;

diff --git a/...DotNet.Blog.IntegrationTests/Web/RegistrationExtensions/StorageProviderExtensionsTests.cs b/...DotNet.Blog.IntegrationTests/Web/RegistrationExtensions/StorageProviderExtensionsTests.cs
@@ -3,7 +3,6 @@
 using LinkDotNet.Blog.Domain;
 using LinkDotNet.Blog.Infrastructure.Persistence;
 using LinkDotNet.Blog.TestUtilities;
-using LinkDotNet.Blog.Web;
 using LinkDotNet.Blog.Web.RegistrationExtensions;
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;

diff --git a/tests/LinkDotNet.Blog.IntegrationTests/Web/Shared/Admin/BlogPostAdminActionsTests.cs b/tests/LinkDotNet.Blog.IntegrationTests/Web/Shared/Admin/BlogPostAdminActionsTests.cs
@@ -4,7 +4,6 @@
 using LinkDotNet.Blog.Domain;
 using LinkDotNet.Blog.Infrastructure.Persistence;
 using LinkDotNet.Blog.Web.Features.ShowBlogPost.Components;
-using Microsoft.AspNetCore.Components;
 using Microsoft.Extensions.DependencyInjection;
 using NCronJob;
 

diff --git a/tests/LinkDotNet.Blog.IntegrationTests/Web/Shared/NavMenuTests.cs b/tests/LinkDotNet.Blog.IntegrationTests/Web/Shared/NavMenuTests.cs
@@ -1,8 +1,6 @@
 using System.Linq;
 using AngleSharp.Html.Dom;
-using LinkDotNet.Blog.Domain;
 using LinkDotNet.Blog.TestUtilities;
-using LinkDotNet.Blog.Web;
 using LinkDotNet.Blog.Web.Features.Home.Components;
 using Microsoft.AspNetCore.Components;
 using Microsoft.Extensions.DependencyInjection;

diff --git a/tests/LinkDotNet.Blog.TestUtilities/SupportMeConfigurationBuilder.cs b/tests/LinkDotNet.Blog.TestUtilities/SupportMeConfigurationBuilder.cs
@@ -1,4 +1,3 @@
-using LinkDotNet.Blog.Web.Features.ShowBlogPost.Components;
 using LinkDotNet.Blog.Web.Features.SupportMe.Components;
 
 namespace LinkDotNet.Blog.TestUtilities;

diff --git a/tests/LinkDotNet.Blog.UnitTests/Web/ApplicationConfigurationTests.cs b/tests/LinkDotNet.Blog.UnitTests/Web/ApplicationConfigurationTests.cs
@@ -1,7 +1,6 @@
 using System.Collections.Generic;
 using LinkDotNet.Blog.Domain;
 using LinkDotNet.Blog.TestUtilities;
-using LinkDotNet.Blog.Web;
 using LinkDotNet.Blog.Web.Authentication.OpenIdConnect;
 using LinkDotNet.Blog.Web.Features.ShowBlogPost.Components;
 using Microsoft.Extensions.Configuration;

diff --git a/tests/LinkDotNet.Blog.UnitTests/Web/Features/Home/Components/FooterTests.cs b/tests/LinkDotNet.Blog.UnitTests/Web/Features/Home/Components/FooterTests.cs
@@ -1,6 +1,4 @@
-using LinkDotNet.Blog.Domain;
 using LinkDotNet.Blog.TestUtilities;
-using LinkDotNet.Blog.Web;
 using LinkDotNet.Blog.Web.Features.Home.Components;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Options;

diff --git a/tests/LinkDotNet.Blog.UnitTests/Web/Features/Home/Components/IntroductionCardTests.cs b/tests/LinkDotNet.Blog.UnitTests/Web/Features/Home/Components/IntroductionCardTests.cs
@@ -1,6 +1,5 @@
 using System.Linq;
 using AngleSharp.Css.Dom;
-using LinkDotNet.Blog.Domain;
 using LinkDotNet.Blog.TestUtilities;
 using LinkDotNet.Blog.Web.Features.Home.Components;
 using Microsoft.Extensions.DependencyInjection;

diff --git a/tests/LinkDotNet.Blog.UnitTests/Web/Features/ShowBlogPost/Components/CommentSectionTests.cs b/tests/LinkDotNet.Blog.UnitTests/Web/Features/ShowBlogPost/Components/CommentSectionTests.cs
@@ -1,5 +1,4 @@
 using LinkDotNet.Blog.TestUtilities;
-using LinkDotNet.Blog.Web;
 using LinkDotNet.Blog.Web.Features.ShowBlogPost.Components;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Options;

diff --git a/tests/LinkDotNet.Blog.UnitTests/Web/Features/ShowBlogPost/Components/DisqusTests.cs b/tests/LinkDotNet.Blog.UnitTests/Web/Features/ShowBlogPost/Components/DisqusTests.cs
@@ -1,6 +1,5 @@
 using System.Linq;
 using LinkDotNet.Blog.TestUtilities;
-using LinkDotNet.Blog.Web;
 using LinkDotNet.Blog.Web.Features.ShowBlogPost.Components;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Options;

diff --git a/tests/LinkDotNet.Blog.UnitTests/Web/Features/ShowBlogPost/Components/DonationSectionTests.cs b/tests/LinkDotNet.Blog.UnitTests/Web/Features/ShowBlogPost/Components/DonationSectionTests.cs
@@ -1,6 +1,4 @@
 using LinkDotNet.Blog.TestUtilities;
-using LinkDotNet.Blog.Web;
-using LinkDotNet.Blog.Web.Features.ShowBlogPost.Components;
 using LinkDotNet.Blog.Web.Features.SupportMe.Components;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Options;

diff --git a/tests/LinkDotNet.Blog.UnitTests/Web/Features/ShowBlogPost/Components/GiscusTests.cs b/tests/LinkDotNet.Blog.UnitTests/Web/Features/ShowBlogPost/Components/GiscusTests.cs
@@ -1,6 +1,5 @@
 using System.Linq;
 using LinkDotNet.Blog.TestUtilities;
-using LinkDotNet.Blog.Web;
 using LinkDotNet.Blog.Web.Features.ShowBlogPost.Components;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Options;

diff --git a/tests/LinkDotNet.Blog.UnitTests/Web/Features/ShowBlogPost/Components/GithubSponsorTests.cs b/tests/LinkDotNet.Blog.UnitTests/Web/Features/ShowBlogPost/Components/GithubSponsorTests.cs
@@ -1,5 +1,4 @@
 using AngleSharp.Html.Dom;
-using LinkDotNet.Blog.Web.Features.ShowBlogPost.Components;
 using LinkDotNet.Blog.Web.Features.SupportMe.Components;
 
 namespace LinkDotNet.Blog.UnitTests.Web.Features.ShowBlogPost.Components;

diff --git a/tests/LinkDotNet.Blog.UnitTests/Web/Features/ShowBlogPost/Components/KofiTests.cs b/tests/LinkDotNet.Blog.UnitTests/Web/Features/ShowBlogPost/Components/KofiTests.cs
@@ -1,5 +1,4 @@
 using AngleSharp.Html.Dom;
-using LinkDotNet.Blog.Web.Features.ShowBlogPost.Components;
 using LinkDotNet.Blog.Web.Features.SupportMe.Components;
 
 namespace LinkDotNet.Blog.UnitTests.Web.Features.ShowBlogPost.Components;

diff --git a/tests/LinkDotNet.Blog.UnitTests/Web/Features/ShowBlogPost/Components/PatreonTests.cs b/tests/LinkDotNet.Blog.UnitTests/Web/Features/ShowBlogPost/Components/PatreonTests.cs
@@ -1,5 +1,4 @@
 using AngleSharp.Html.Dom;
-using LinkDotNet.Blog.Web.Features.ShowBlogPost.Components;
 using LinkDotNet.Blog.Web.Features.SupportMe.Components;
 
 namespace LinkDotNet.Blog.UnitTests.Web.Features.ShowBlogPost.Components;

diff --git a/tests/LinkDotNet.Blog.UnitTests/Web/Features/ShowBlogPost/ShowBlogPostPageTests.cs b/tests/LinkDotNet.Blog.UnitTests/Web/Features/ShowBlogPost/ShowBlogPostPageTests.cs
@@ -1,5 +1,3 @@
-using System;
-using System.Linq.Expressions;
 using System.Threading.Tasks;
 using AngleSharp.Html.Dom;
 using Blazored.Toast.Services;