Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update drivers.md - IBM Block storage driver 1.12.0 supports RWX, no more support for A9000 #606

Closed
wants to merge 1 commit into from
Closed

Update drivers.md - IBM Block storage driver 1.12.0 supports RWX, no more support for A9000 #606

wants to merge 1 commit into from

Conversation

csiblock
Copy link
Contributor

@csiblock csiblock commented Nov 6, 2024

No description provided.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Nov 6, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 6, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 6, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @csiblock!

It looks like this is your first PR to kubernetes-csi/docs 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/docs has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 6, 2024
@csiblock
Copy link
Contributor Author

csiblock commented Nov 6, 2024

/release-note-edit "IBM Block storage driver 1.12.0 supports RWX, no more support for A9000"

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 6, 2024
@csiblock
Copy link
Contributor Author

csiblock commented Nov 6, 2024

/release-note-edit "IBM Block storage driver 1.12.0 supports RWX, no more support for A9000"

@csiblock
Copy link
Contributor Author

csiblock commented Nov 6, 2024

/lgtm

@k8s-ci-robot
Copy link
Contributor

@csiblock: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@csiblock
Copy link
Contributor Author

csiblock commented Nov 6, 2024

/assign @lpabon

@csiblock
Copy link
Contributor Author

csiblock commented Nov 6, 2024 •
edited
Loading

@lpabon please review and approve this PR

@xing-yang if you can review , it would be most appreciated

@xing-yang
Copy link
Contributor

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 6, 2024
@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csiblock, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2024
@csiblock
Copy link
Contributor Author

csiblock commented Nov 6, 2024

thank you @xing-yang

the pull / build task is failing due to "Error: This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v2. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/"
how can we fix this?

@xing-yang
Copy link
Contributor

@csiblock I'm not sure. I have not seen this error before. You may need to try to submit a new PR.

@csiblock
Copy link
Contributor Author

csiblock commented Nov 6, 2024 •
edited
Loading

@xing-yang this PR was created today
seems there is an issue in the actions configured in this repo

i created PR #607 to fix this issue. can you please review and approve it? then i can hopefully retrigger this PR

@csiblock csiblock mentioned this pull request Nov 6, 2024
Merged
@csiblock
Copy link
Contributor Author

csiblock commented Nov 6, 2024

/retest

@k8s-ci-robot
Copy link
Contributor

@csiblock: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@csiblock
Copy link
Contributor Author

csiblock commented Nov 6, 2024

/reset

@csiblock
Copy link
Contributor Author

csiblock commented Nov 6, 2024

closing this PR, as new PR #608 created so that updated pull / build check be run properly, now that PR #607 is merged

@csiblock csiblock closed this Nov 6, 2024
@csiblock csiblock mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpabon lpabon Awaiting requested review from lpabon

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@xing-yang xing-yang

@lpabon lpabon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@csiblock @k8s-ci-robot @xing-yang @lpabon