Persist admin event only when roles is non-empty#35162
Merged
pedroigor merged 1 commit intokeycloak:mainfrom Nov 29, 2024
Merged
Persist admin event only when roles is non-empty#35162pedroigor merged 1 commit intokeycloak:mainfrom
pedroigor merged 1 commit intokeycloak:mainfrom
Conversation
2 tasks
venkatesh2090
force-pushed
the
role-mapping-event
branch
from
48975a4 to
22e9c38
Compare
Contributor
|
@ahus1 @pedroigor Could any of you please trigger the CI for this one? Changes LGTM as they prevent creation of redundant events. |
sguilhen
approved these changes
Nov 26, 2024
Currently, an adminEvent is created regardless of if the roles passed to the role-mapping API is empty. The event should only be created when the list `roles` is non-empty. Closes keycloak#33195 Signed-off-by: Venkatesh Kannan <[email protected]>
venkatesh2090
force-pushed
the
role-mapping-event
branch
from
22e9c38 to
9f698ba
Compare
Member
|
@venkatesh2090 - please avoid rebasing the PR unless you are asked by a reviewer or GitHub shows a conflict. Any rebased would invalidate previous reviews. @sguilhen - can you please re-review? Thanks. |
Contributor
|
@ahus1 Sure, I can - in the meantime would you be able to re-run the failing tests? Don't seem related to me. |
pedroigor
approved these changes
Nov 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, an adminEvent is created regardless of if the roles passed to the role-mapping API is empty. The event should only be created when the list
rolesis non-empty.Closes #33195