-
Notifications
You must be signed in to change notification settings - Fork 75
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: update to esbuild 0.10.0 and xdm 1.6.0, fix tests not running
- Loading branch information
Showing
2 changed files
with
7 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ee6c8d9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately something weird happened with jest between our last release and this commit. I can't get the tests working now.
Hopefully you didn't need this released soon 😅
Please make PRs instead of committing directly to main in the future :)
ee6c8d9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kentcdodds yeah this is weird. My machine was happy with it no problem so I figured after updating esbuild and xdm and adding the extra esmodule for the xdm release notes it would be fine like it was on machine.
Once it failed again I cleared my jest cache and was able to reproduce it. I have a pr branch now that I'm working on a fix in.
Sorry for going straight to main but as it should have been a minor dependancy bump that was passing locally I thought it would have been fine.
ee6c8d9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll keep going with my PR branch and testing that but I'm moving house this weekend/next week which is going to severly limit dev time so it might be a while before it surfaces.
ee6c8d9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries. You are right. A little version bump like that should be fine.
I'm starting to think it might be worthwhile to switch to a different testing framework for this project...