Skip to content

Commit

Permalink
fix: update to esbuild 0.10.0 and xdm 1.6.0, fix tests not running
Browse files Browse the repository at this point in the history
  • Loading branch information
Arcath committed Mar 25, 2021
1 parent f74f73a commit ee6c8d9
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
1 change: 1 addition & 0 deletions jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ const esModules = [
'periscopic',
'remark-mdx-frontmatter',
'js-yaml',
'estree-util-is-identifier-name',
].join('|')

module.exports = Object.assign(configs.jest, {
Expand Down
12 changes: 6 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,25 +41,25 @@
},
"dependencies": {
"@babel/runtime": "^7.13.10",
"@esbuild-plugins/node-resolve": "0.0.14",
"@esbuild-plugins/node-resolve": "0.0.15",
"@fal-works/esbuild-plugin-global-externals": "^2.1.1",
"esbuild": "0.9.0",
"esbuild": "^0.10.0",
"gray-matter": "^4.0.2",
"remark-frontmatter": "^3.0.0",
"remark-mdx-frontmatter": "^1.0.0",
"xdm": "^1.5.1"
"xdm": "^1.6.0"
},
"devDependencies": {
"@testing-library/react": "^11.2.5",
"@types/jest": "^26.0.20",
"@types/react": "^17.0.3",
"@types/react-dom": "^17.0.2",
"@types/react-dom": "^17.0.3",
"jest-environment-jsdom": "^26.6.2",
"jest-module-field-resolver": "0.0.1",
"kcd-scripts": "^8.1.0",
"left-pad": "^1.3.0",
"react": "^17.0.1",
"react-dom": "^17.0.1",
"react": "^17.0.2",
"react-dom": "^17.0.2",
"typescript": "^4.2.3"
},
"eslintConfig": {
Expand Down

4 comments on commit ee6c8d9

@kentcdodds
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately something weird happened with jest between our last release and this commit. I can't get the tests working now.

Hopefully you didn't need this released soon 😅

Please make PRs instead of committing directly to main in the future :)

@Arcath
Copy link
Collaborator Author

@Arcath Arcath commented on ee6c8d9 Mar 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kentcdodds yeah this is weird. My machine was happy with it no problem so I figured after updating esbuild and xdm and adding the extra esmodule for the xdm release notes it would be fine like it was on machine.

Once it failed again I cleared my jest cache and was able to reproduce it. I have a pr branch now that I'm working on a fix in.

Sorry for going straight to main but as it should have been a minor dependancy bump that was passing locally I thought it would have been fine.

@Arcath
Copy link
Collaborator Author

@Arcath Arcath commented on ee6c8d9 Mar 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll keep going with my PR branch and testing that but I'm moving house this weekend/next week which is going to severly limit dev time so it might be a while before it surfaces.

@kentcdodds
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. You are right. A little version bump like that should be fine.

I'm starting to think it might be worthwhile to switch to a different testing framework for this project...

Please sign in to comment.