Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix schema resolution using Samba share on Windows #3313

Merged
merged 3 commits into from
Jan 4, 2025
Merged

Fix schema resolution using Samba share on Windows #3313

merged 3 commits into from
Jan 4, 2025

Conversation

edoren
Copy link
Contributor

@edoren edoren commented Dec 1, 2024

Hello!

While using this extension via the Samba share addon on Windows I noticed that the schemas were not working properly, in the logs I noticed that only the first backslash was being replaced and this was triggering the issue in the schema resolution of yaml-language-server:

Applying schemas to 10 of your configuration files...
Assigning /%5C192.168.1.102%5Cconfig%5Cconfiguration.yaml the configuration.yaml schema
Assigning /%5C192.168.1.102%5Cconfig%5Cautomations.yaml the configuration.yaml/automation schema
Assigning /%5C192.168.1.102%5Cconfig%5Cautomations.yaml the configuration.yaml/automation schema
Assigning /%5C192.168.1.102%5Cconfig%5Cscripts.yaml the configuration.yaml/script schema
Assigning /%5C192.168.1.102%5Cconfig%5Cscenes.yaml the configuration.yaml/scene schema
Assigning /%5C192.168.1.102%5Cconfig%5Cbinary_sensor.yaml the configuration.yaml/binary_sensor schema
Schemas updated!

I also saw this comment from someone that had a similar issue. After this change the entry is registered properly and the schemas work:

Applying schemas to 10 of your configuration files...
Assigning //192.168.1.102/config/configuration.yaml the configuration.yaml schema
Assigning //192.168.1.102/config/automations.yaml the configuration.yaml/automation schema
Assigning //192.168.1.102/config/automations.yaml the configuration.yaml/automation schema
Assigning //192.168.1.102/config/scripts.yaml the configuration.yaml/script schema
Assigning //192.168.1.102/config/scenes.yaml the configuration.yaml/scene schema
Assigning //192.168.1.102/config/binary_sensor.yaml the configuration.yaml/binary_sensor schema
Schemas updated!

frenck
frenck requested changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @edoren 👋

The CI is failing, could you please take a look?

Thanks! 👍

../Frenck

@edoren
Copy link
Contributor Author

edoren commented Dec 11, 2024

It seems replaceAll is part of es2021, I can do the change to update it on the tsconfig.json, but before that, is there any reason why es2020 is still used?

@frenck
Copy link
Collaborator

frenck commented Dec 12, 2024

@edoren I wish I could tell you :) I'm not a JS developer at all.

../Frenck

@edoren edoren requested a review from frenck January 4, 2025 13:43
frenck
frenck approved these changes Jan 4, 2025
View reviewed changes
Copy link
Collaborator

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @edoren 👍

../Frenck

@frenck frenck added the bug Something isn't working label Jan 4, 2025
@frenck frenck merged commit f045f50 into keesschollaart81:dev Jan 4, 2025
@edoren
Copy link
Contributor Author

edoren commented Jan 4, 2025 •
edited
Loading

Sorry I noticed a check failed, I'm fixing it right away!

Edit:
Here it is
#3346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edoren @frenck