Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV to 1.70 #731

Closed
wants to merge 1 commit into from
Closed

Conversation

marmeladema
Copy link

This project follows Tokio MSRV which is now at 1.70.
Additionally, this allows to use panic in constant to simplify some code.

This project follows Tokio MSRV which is now at 1.70.
Additionally, this allows to use panic in constant to simplify
some code.
@seanmonstar
Copy link
Member

Hm, that comment in the README is likely wrong, this more closely follows hyper's policy: https://github.com/hyperium/hyper/blob/master/docs/MSRV.md

Which I'm not so sure I'd want to increase it for better panic messages, as Debian stable still has 1.63.

@marmeladema
Copy link
Author

Thank you for your inputs.
Bumping to 1.63 would still be enough to get const panics.
I will update the proposal to that version but if that's still not appropriate, feel free to close this.

@seanmonstar
Copy link
Member

Closing, but if you want to submit a bump to 1.63, we could merge that!

@seanmonstar seanmonstar closed this Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants