Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not explicit copy data before sending #234

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

do not explicit copy data before sending #234

wants to merge 6 commits into from

Conversation

Ruben2424
Copy link
Contributor

I am not sure if this is the best way to write this or if it gains performance. I am happy to get Feedback.

@seanmonstar
Copy link
Member

Good idea! Do things have to be Send? If we don't need it, people can choose to use single threaded types.

@Ruben2424
Copy link
Contributor Author

Good idea! Do things have to be Send? If we don't need it, people can choose to use single threaded types.

@seanmonstar I think they have to be Send because data is moved into the ReusableBoxFuture.
Maybe i could bring back the old implementation where B: !Send?

@Ruben2424
Copy link
Contributor Author

Ruben2424 commented Mar 24, 2024 •
edited
Loading

Maybe i could bring back the old implementation where B: !Send?

Ok i think this is not possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ruben2424 @seanmonstar