Skip to content

Commit

Permalink
Emphasize that a branch/PR should have closely-related changes.
Browse files Browse the repository at this point in the history
This is the result of a discussion on how to make cherry-picking
easier for the One That Merges during the 2015-12-07 (or -08,
depending on your time zone) OpenShift writers' meeting.
  • Loading branch information
tnguyen-rh committed Dec 10, 2015
1 parent 7e95923 commit 98c62ae
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
6 changes: 5 additions & 1 deletion contributing_to_docs/contributing.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@ There are a few different ways you can contribute to OpenShift documentation:
* https://github.com/openshift/openshift-docs/issues/new[Create an issue in
GitHub]
* If you would like to do the work yourself, or if it is a substantial change,
then you you should clone the repository, make your changes, and submit a PR
then you you should clone the repository, make your changes, and submit a PR.
Each PR should have closely-related changes.
In particular, it is a good idea to use separate PRs
for bugfix changes (for an old or current release)
vs enhancement changes (for an upcoming new release).

*What happens when you submit a PR?*

Expand Down
5 changes: 5 additions & 0 deletions contributing_to_docs/create_or_edit_content.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,11 @@ any new content.

The following command creates a new local branch and checks it out
automatically. Be sure to replace `<working_branch>` with a suitable name.
Also, be sure that the changes made on this branch are closely related and
do indeed reflect that name.
In particular, it is a good idea to use separate PRs
for bugfix changes (for an old or current release)
vs enhancement changes (for an upcoming new release).

----
$ git checkout -b <working_branch>
Expand Down

0 comments on commit 98c62ae

Please sign in to comment.