Don't set CMAKE_INSTALL_<dir>. (JuliaLang#46061)

maleadt · web-flow · commit b9b60fcde61f · 2022-08-19T09:36:45.000+02:00
According to the docs, https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html#module:GNUInstallDirs, it should be a relative path that will automatically be prefixed wit the CMAKE_INSTALL_PREFIX (which we already set). That means the default values, https://cmake.org/cmake/help/latest/command/install.html, should work just fine.
diff --git a/deps/tools/common.mk b/deps/tools/common.mk
@@ -19,7 +19,6 @@ CMAKE_CC_ARG := $(CC_ARG)
 CMAKE_CXX_ARG := $(CXX_ARG)
 
 CMAKE_COMMON := -DCMAKE_INSTALL_PREFIX:PATH=$(build_prefix) -DCMAKE_PREFIX_PATH=$(build_prefix)
-CMAKE_COMMON += -DCMAKE_INSTALL_LIBDIR=$(build_libdir) -DCMAKE_INSTALL_BINDIR=$(build_bindir)
 CMAKE_COMMON += -DLIB_INSTALL_DIR=$(build_shlibdir)
 ifeq ($(OS), Darwin)
 CMAKE_COMMON += -DCMAKE_MACOSX_RPATH=1
