Don't set CMAKE_INSTALL_<dir>. #46061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the docs, https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html#module:GNUInstallDirs, it should be a relative path that will automatically be prefixed wit the CMAKE_INSTALL_PREFIX (which we already set). That means the default values, https://cmake.org/cmake/help/latest/command/install.html, should work just fine.
|
Can be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It confuses GNUInstallDirs on Windows (both locally, and on CI), breaking LLVM source builds.
According to the docs, https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html#module:GNUInstallDirs,
it should be a relative path that will automatically be prefixed wit the CMAKE_INSTALL_PREFIX (which
we already set). That means the default values, https://cmake.org/cmake/help/latest/command/install.html,
should work just fine.