Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage sub TS migration #119

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Usage sub TS migration #119

wants to merge 12 commits into from

Conversation

DevAOC
Copy link
Collaborator

@DevAOC DevAOC commented Nov 6, 2024

No description provided.

@DevAOC DevAOC requested a review from rdraward November 6, 2024 21:19
rdraward
rdraward reviewed Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@rdraward rdraward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 🎩 works well
This one uses lots of type casting. If something can be null or undefined, we should probably check and handle, instead of just casting the type warnings away

shopify/usage-subscription-template/api/models/shopifyShop/actions/uninstall.ts Show resolved Hide resolved
shopify/usage-subscription-template/web/components/PlanCard.tsx Show resolved Hide resolved
shopify/usage-subscription-template/web/components/PlanCard.tsx Outdated Show resolved Hide resolved
shopify/usage-subscription-template/api/actions/chargeShop.ts Outdated Show resolved Hide resolved
shopify/usage-subscription-template/api/actions/chargeShop.ts Outdated Show resolved Hide resolved
@DevAOC DevAOC requested a review from rdraward November 11, 2024 22:08
rdraward
rdraward reviewed Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@rdraward rdraward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over the cap testing did not seem to work. There was an error in the logs and no record of the overage recorded for the shop

CleanShot 2024-11-22 at 10 10 17@2x

Code is good, just some additional nitpicky type handling stuff

shopify/usage-subscription-template/api/models/shopifyShop/actions/subscribe.ts Outdated Show resolved Hide resolved
shopify/usage-subscription-template/api/actions/billingPeriodTracking.ts Outdated Show resolved Hide resolved
shopify/usage-subscription-template/api/models/shopifyOrder/actions/create.ts Outdated Show resolved Hide resolved
shopify/usage-subscription-template/api/models/shopifyOrder/actions/create.ts Outdated Show resolved Hide resolved
@DevAOC DevAOC requested a review from rdraward November 25, 2024 19:33
@DevAOC
Copy link
Collaborator Author

DevAOC commented Nov 26, 2024

Over the cap testing did not seem to work. There was an error in the logs and no record of the overage recorded for the shop

CleanShot 2024-11-22 at 10 10 17@2x

Code is good, just some additional nitpicky type handling stuff

This should be fixed btw

rdraward
rdraward approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@rdraward rdraward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎩 ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdraward rdraward rdraward approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DevAOC @rdraward