Monthly subscription template to ts #113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he test subscriptions don't work anymore with the current Billing API version
rdraward
approved these changes
Nov 6, 2024
shopify/monthly-subscription-template/api/models/shopifyShop/actions/subscribe.ts
Outdated
Show resolved
Hide resolved
shopify/monthly-subscription-template/api/models/shopifyShop/actions/subscribe.ts
Outdated
Show resolved
Hide resolved
shopify/monthly-subscription-template/api/models/shopifyShop/actions/subscribe.ts
Outdated
Show resolved
Hide resolved
…ctions/subscribe.ts Co-authored-by: Riley Draward <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding all the types for the monthly sub template // I noticed that the test subscriptions don't work anymore with the current Billing API version
Idk if I'm doing something wrong with the AppSubscriptionCreate call. Do you mind taking a look at the at that and seeing if it's not me being dumb?
I removed the the plan price conversion because I couldn't find an alternative and it had no type declarations