-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ts migration for openai apps and customized bundle template #112
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review. No tophat, but I went through the code. A couple questions about types and such
shopify/customized-bundle-template/web/components/BundleCard.tsx
Outdated
Show resolved
Hide resolved
openai/ai-screenwriter-template/api/actions/findSimilarMovies.ts
Outdated
Show resolved
Hide resolved
shopify/customized-bundle-template/web/components/UpdateForm.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Riley Draward <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another note - we should include the name of the required environment variable in the template instructions BUNDLE_FUNCTION_ID instead of just saying "Add this function id to the environment variables of your development environment."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The publicationId issue must be why there are duplicate bundles. Did you see retries in the logs for bundle creation? |
The issue is fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple nits based on console errors in the problem drawer but approving because the tophat works well
Please let me know if you have any questions.