Product reviews template #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… time use route // Need to push people to an error or message page when the route they are trying to hit is expired
…ers can't see different pages
…e seems to still persist with Shopify only having the ids of the metaobjects as te metafield
rdraward
reviewed
Oct 29, 2024
There was a problem hiding this comment.
A couple of early comments about how the app is structured, how emails are send/codes are managed
I also need more instructions to tophat this properly. Went through some code to figure out the fulfill order -> send email (need access in Partners dashboard) -> custom frontend route path but it requires a bunch of jumping between files. We should have all this documented so devs can read how the app works
shopify/product-reviews-template/api/models/shopifyShop/actions/install.js
Outdated
Show resolved
Hide resolved
shopify/product-reviews-template/extensions/product-reviews/blocks/productReviews.liquid
Show resolved
Hide resolved
shopify/product-reviews-template/api/actions/sendReviewRequests.js
Outdated
Show resolved
Hide resolved
shopify/product-reviews-template/api/actions/sendReviewRequests.js
Outdated
Show resolved
Hide resolved
shopify/product-reviews-template/api/actions/sendReviewRequests.js
Outdated
Show resolved
Hide resolved
…nformation in readme
|
All the concerns should have been addressed now |
|
Maybe I should add some comments in the code as well, what do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please let me know if there's anything you would change or you think we should add