Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Schema with no required fields crashes (#598) #619

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Schema with no required fields crashes (#598) #619

wants to merge 1 commit into from

Conversation

yswf
Copy link

@yswf yswf commented May 20, 2024 •
edited
Loading

If none of the required=True schemas is set, an error message will be displayed

# error
class LocationInfo(Schema):
    ip = fields.IPv4()
    location = fields.Str(metadata={'example': '4A'})

# Setting required=True will result in no error
class LocationInfo(Schema):
    ip = fields.IPv4(required=True)
    location = fields.Str(metadata={'example': '4A'})
if len(definitions[v.__name__]['required']) != 0:
      ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^

KeyError: 'required'

So I added check if required exists before reading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yswf