4 trivia - cleanups and tiny fixes #525
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, removing the lone print() call makes the code more consistent. setup_logging() already relies on an initial `log` object being setup elsewhere, pointing to stderr. I think that is pretty conventional. python's built-in logging module works the same way.
…ypo?) Exit status 1 is fine. We don't need to use a confusing negative underflow to exit status 255 here.
The "right place" already has the same comment.
erig0
requested changes
Oct 9, 2019
| @@ -170,8 +170,8 @@ def startup(args): | |||
| def main(): | |||
| # firewalld should only be run as the root user | |||
| if os.getuid() != 0: | |||
| print("You need to be root to run %s." % sys.argv[0]) | |||
| sys.exit(-1) | |||
| log.fatal("You need to be root to run %s." % sys.argv[0]) | |||
There was a problem hiding this comment.
This won't work. Logging isn't set up yet.
There was a problem hiding this comment.
Thanks for (amazingly quick :-) review. It works for me:
$ src/firewalld
FATAL ERROR: You need to be root to run src/firewalld.
Do you disagree with the commit message? 4dccb48
I can change it to sys.stderr.write() if you prefer. It just seems a pity for the logging to implement this elegant convention, and then shy away from using it.
thom311
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I found these trivia while looking at error handling. The rest of my work didn't seem to depend on them. So I've split these ones out, to help keep things manageable.
(If you want to leave reviewing this until I send the more hefty PR(s) as well, that's fine :-).
Thanks
Alan