fix(type): item in isItemDisabled may be undefined (fixes #1623) #1631

KrzysztofKarol · 2025-01-03T10:39:15Z

What:

Typings changed. Item in isItemDisabled may be undefined, e. g.

downshift/src/hooks/utils.js

Line 659 in 59d3498

props.isItemDisabled(props.items[highlightedIndex], highlightedIndex)

Why:

Developers should handle this case to avoid runtime errors.

How:

Only typings changed.

Checklist:

Fixes #1623

Offtopic
Probably types of others methods should be check and fixed
e.g.

-itemToString?: (item: Item | null) => string
+itemToString?: (item: Item | undefined) => string

because

downshift/src/hooks/utils.js

Line 609 in 59d3498

inputValue: props.itemToString(props.items[highlightedIndex]),

fix(type): item in isItemDisabled may be undefined

1cbe95e

KrzysztofKarol changed the title ~~fix(type): item in isItemDisabled may be undefined~~ fix(type): item in isItemDisabled may be undefined (fixes #1623) Jan 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(type): item in isItemDisabled may be undefined (fixes #1623) #1631

fix(type): item in isItemDisabled may be undefined (fixes #1623) #1631

KrzysztofKarol commented Jan 3, 2025 •

edited

Loading

fix(type): item in isItemDisabled may be undefined (fixes #1623) #1631

Are you sure you want to change the base?

fix(type): item in isItemDisabled may be undefined (fixes #1623) #1631

Conversation

KrzysztofKarol commented Jan 3, 2025 • edited Loading

KrzysztofKarol commented Jan 3, 2025 •

edited

Loading