feat: allow disabling selected item events #1297
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! We don't support |
korczas
force-pushed
the
feat/support-disable-prop
branch
from
08aa103 to
2309155
Compare
|
@silviuaavram Hi. I am not sure if I understood correctly what u meant by creating a Feature Request, by I have updated PR description with the template, added TS definition and updated docs. It seems that flow-types doesn't need any update, but I might be wrong. |
korczas
force-pushed
the
feat/support-disable-prop
branch
from
2309155 to
b277633
Compare
korczas
force-pushed
the
feat/support-disable-prop
branch
from
b277633 to
74d1f2c
Compare
|
@silviuaavram Hi, feature is ready to ship. |
|
Hey i wanted to ask what the status of this pull request is, as i would be also interested in the possibility to disable some of my elements from a list for selection. |
|
Well yes, all good so far, thank you! But if the item is disabled, it should be skipped during navigation. This PR needs more work and tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
New feature, which supports
disabledprop forgetSelectedItemPropsmethod.Why:
When using
useMultipleSelection()hook there is no support for disablingBackspaceandDeletekeys events and prevent from editing data.How:
If
disabledprop is passed togetSelectedItemProps, thenonClickandonKeyDownhandlers are not returned.Checklist: