Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When retrying to resolveOrCreateNetwork, retry with a valid network name #12422

Merged
merged 1 commit into from
Jan 6, 2025
Merged

When retrying to resolveOrCreateNetwork, retry with a valid network name #12422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
When retrying to resolveOrCreateNetwork, retry with a valid network name 
Signed-off-by: Guillaume Tardif <[email protected]>
  • Loading branch information
@gtardif
gtardif committed Dec 24, 2024
commit bed7999a699c5f3f1883998364589a0520e37a13
2 changes: 1 addition & 1 deletion pkg/compose/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1220,7 +1220,7 @@ func (s *composeService) ensureNetwork(ctx context.Context, project *types.Proje
if errdefs.IsConflict(err) {
// Maybe another execution of `docker compose up|run` created same network
// let's retry once
return s.resolveOrCreateNetwork(ctx, project, "", n)
return s.resolveOrCreateNetwork(ctx, project, name, n)
}
return id, err
}
Expand Down
Loading